comment on

First of all start with this node: How to get the most of your question from the monks. It has a lot of good info for newbies. Pay attention for tips about 'use strict' and '-w'. It is must have!
Well, next step separate your code on several subroutines. Rule of thumb that no subroutine show exceed one screen. That meens 25 lines. All rules have exceptions but usually long subroutine means bad style.
Use DBI's placeholders. See perldoc DBI and What are placeholders in DBI, and why would I want to use them?.
There is no need for very long completly unreadable lines like in chunk of your code which creates new table. It can be rewritten using heredocs (see Here, doccy doccy. nice doccy. heredoc, treat.). Something like
```
$sql->do(<<SQL);
CREATE TABLE IF NOT EXISTS %log (
    id INT (100) not null AUTO_INCREMENT,
    log1 CHAR (255) not null,
    ....
    ....
)
SQL
[download]
```
It looks much more readable. Note that I've replaced several method calls prepare, excute. finish with single do.

Loops like


for($$i=0; $i<$#watcher+1; $i++) {
    $watch="$watcher[$i]";
    ...
    ...
}
[download]

Can be rewritten as


for my $watch (@watcher) {
}
[download]

Well, and finally memory leaks. I think they are caused by using prepare_cached without thinking. prepare_cached caches statement handler for all queries so for same queries one statement handler can be reused. First of all it doesn't makes too much sense for MySQL because it cannot actually prepare queries for later reuse like Oracle (and probably don't need to do it since it is much more lightweight SQL server). Second of all all your queries are different since you do not use placeholders. For now replace prepare_cached with just prepare and reread docs for DBI. Probably your problems will go away.

In reply to Re: Clean Code - What a mess... by IlyaM
in thread Clean Code - What a mess... by PyroX

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		`&`
	<		`<`
	>		`>`
	[		`[`
	]		`]`

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.