To tell you the truth, your code is horrible.

• You're not using placeholders
• You're warning the return value of a print statement. Why?
• You're undefining @data_array, yet @data_array is neither used nor declared in your code.
• What does this code do, anyway? Your description wasn't very clear, and from the looks of your code its use appears to be restricted to a very small scope.

Here's a rewrite:

# "RaiseError => 1" tells DBI to die on errors.
my $dbh = DBI->connect($DSN, $username, $password, { RaiseError => 1 }
+);

my $sth;

$sth = $dbh->prepare("
          SELECT table_name, column_name
          FROM Dba_tab_columns
          WHERE owner = ?
          ORDER BY table_name, column_name
        ");

$sth->execute($schema);

my $table_column = $sth->fetchall_arrayref;

$sth->finish;
        
for my $tcr (@{$table_column}) {
  if ($tcr->[0] eq "EMP") {
    my $sth = $dbh->prepare("SELECT " . $tcr->[1] . " FROM " . $schema
+ . $tcr->[0]);
    $sth->execute;

    my $column_data = $sth->fetchall_arrayref;
    $sth->finish;
                
    # This for-loop create a hash of a hash of an array with the keys 
+{table name} and {column name}
    for my $row (@{$column_data}) {
      push @{ $tables{$tcr->[0]}{$tcr->[1]} }, $row->[0];             
+      
    }
  }
}
[download]

[ ar0n -- want job (boston) ]

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.