Don't hardcode the classname. This will break inheritance, if you ever need it. Also, you weren't using strict in your package. Shame on you! :)

package db_dave;
use strict;
use DBI;
use vars qw/ @ISA /;
@ISA = qw/DBI/;

sub new
{
    my $class = shift;
    my $dbh = DBI->connect('dbi:Oracle:foo', 'foo', 'foo', { RaiseErro
+r => 1 })
        || die "Cant' connect: $DBI::errstr";
    my $data = {
        _dbh => $dbh
    };
    bless $data, $class;
    return $data;
}

sub runsql_returnString_NEW
{
    my ($self, $q, $err) = @_;
    my $dbh = $self->{ _dbh };
    my $sth = $dbh->prepare($q);
    $sth->execute || &error($q, $err); # <- why do you have a regular 
+function in an OO module?

    my $returnstring;
    while (my @array = $sth->fetchrow) {
        # ?? You're overwriting this every time :(
        # I can't tell what type of data structure you want
        $returnstring = $array[0];
    }

    $sth->finish;
    return $returnstring;

}

[download]

That should give you a start (though the code is untested). It needs a lot of work.

Cheers,
Ovid

Join the Perlmonks Setiathome Group or just click on the the link and check out our stats.

In reply to (Ovid) Re: problems wrapping DBI by Ovid
in thread problems wrapping DBI by mr.dunstan

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.