I'd never thought it through particularly, since in my case it is much less likely anyone else will have to read my code, but readability does seem to be quite a personal thing. I think there are some styles that are going to be less readable for almost everyone, but a lot of cases where it's totally dependent on the reader. I probably betray my own sloppy habits when I say I found your version one easier to understand than version two.

My {pre-decimalisation pound} / 120 is that the map version wd be more readable like this: 
my @files = map {&makefiles} @in;

sub
makefiles
{
    my ($count, $file) = split;

    $file =~ s/^$in_prefix//;

    my ($campaign, $month, $fname) = split /\//, $file;

    return {        # not strictly necessary, but *readable*
        campaign => $campaign,
        month => $month,
        file => $fname,
        count => $count,
        sort => "$campaign:$month:$file"
    };
}

[download]


§ George Sherston

In reply to Re: Do as I say. Not as I do by George_Sherston
in thread Do as I say. Not as I do by davorg

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.