Bad code: 
#Get the user's email, this is fine
use CGI;
$q = new CGI unless @ARGV;
$email = $ARGV[0] || $q->param("email");

#Open sendmail to send the mail, this is not fine
open(MAIL, "|/usr/lib/sendmail $email");
print MAIL $mailMessage;

[download]
That open is not safe because somebody could craft a very nasty command and pass it to you via a form. eg; email: bob@aoheck.com < rm -rfv /

Congratulations, this would send an email to bob containing all the names of the files you no longer have.

UPDATE: Obviously -T (taint) is your friend.

--
perl -p -e "s/(?:\w);([st])/'\$1/mg"

In reply to Re: bad email code? by belg4mit
in thread bad email code? by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.