Hi,

There's only one thing really wrong: you shouldn't use backticks with open. Backticks are for when you need all output in a scalar or array, using $list = `ls` or @list = `ls`
I think the "ls $file|" really had to be "ls $mask|".

Calling an external program for simple things like this is considered bad style. Perl has its own ways of listing files: glob, with which you can shell-like globs (* and ? wildcards) and opendir/readdir/closedir.

And another thing about style: most people use ALLCAPS for their file handle names, and all lowercased characters for normal identifiers. These "rules" are described in perlstyle.

sub fill_list {
 my ($mask, $file) = @_;
  # somewhat more efficient than two shifts
 open (LIST, '>', $file) or die "Couldn't open $file: $!";
 
 for (glob($mask)){
  print LIST "$_\n";
 }

 close LIST;
}

[download]
Instead of the for-loop, it can be done using a single print statement: 
 print LIST map("$_\n", glob($mask));

[download]
Please note some people consider glob() to be as evil as calling an external program, and some computers have bad libraries, which can cause some trouble when there are file names with spaces in them. (These bad libraries list the two files "File name" and "Hello, World!" as if it were four files: "File", "name", "Hello,", "World!"). 

2;0 juerd@ouranos:~$ perl -e'undef christmas'
Segmentation fault
2;139 juerd@ouranos:~$

[download]

In reply to Re: File problems by Juerd
in thread File problems by coec

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.