Hi,
I should say your script looks pretty good ;-). Sorry, I didn't have much time to _really_ study into it, but here's what I've found after a quick scan:
In your xqsend() subroutine, you have the following:
if ($_[0]) {
my $user_index = $_[0];
$user = $xdccqueue[$user_index - 1]{user};
} else {
$user = $xdccqueue[0]{user};
#IRC::print("$CX Checking for$CB $user$CX from queue... $CO\n");
}
First, you don't need to initialize the
$user_index variable to simply store
the value of the first subroutine argument, considering
that the only place you use it is in the line immediately
below its initialization.
Therefore, I'd propose to exchange your if/else block for
this:
$user = $xdccqueue[(($_[0] || 1) - 1)]{user};
Or, better yet, just use this:
$user = $xdccqueue[$_[0]]{user};
since
(qw(foo bar))[$_[0]]
would still yield 'foo' when @_ is empty (therefore,
$_[0] is undef).
"There is no system but GNU, and Linux is one of its kernels." -- Confession of Faith
|
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
|
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.