I'm not sure why, but I have a couple of comments anyway. Why do you use quotes around something that is a string anyway? i.e.: $hash_ref->{"$meta_configs{login_username}"}; looks better as $hash_ref->{$meta_configs{login_username}}; and $dbh->prepare("$sql") makes more sense as $dbh->prepare($sql)

Also, you could consider using a module such as Mail::Sendmail which means your code is a lot more portable, especially on systems where /usr/lib/sendmail doesn't exist, which I assume will be plentiful. It also should fix the problem with taint.

Also why the convulted way to get the username and password, whats wrong with: 

my ($email, $user, $pass) = $sth->fetchrow_array;

[download]

In reply to Re: why is this tainted? by gav^
in thread why is this tainted? by michellem

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.