This is the revised question and code, many thanks go to jepri for all the changes, and the obvious mistake I made (didn't use strict;) anyways, on to the real question, but first a little background. I am creating a simple news database program that saves to a DBM style database, and can add entries into it, using hashes. I am also using HTML::Template for the first real time to seperate the code from the HTML. My question is, how can I have this code snippet display all of the database entries in a table? Also a second question I have about implementing this type of code, is: how can I display all the entries in a form where each of the contents of each hash row is seperated ... like by using split? Thanks for any help! note:I have not added the file lock yet, but that will be added before I actually use this code in a bigger project later. I am sure that there is a lot of the program that could be much more efficient than it is, if so, please let me know, so I can learn and fix it! Thanks again.

Here is the first file, the actual code file (news.pl): 

#!/usr/bin/perl -w
use strict;
use HTML::Template;
use CGI qw (:standard);
use CGI::Carp qw(fatalsToBrowser);
use DB_File;

my @fields = ("title","date","author","news");
my $q = new CGI;
print $q->header;

my $template = HTML::Template->new(filename => 'news.tmpl');

my $filename="database.db";
tie(my %hash, "DB_File", $filename) or die "Can't open $filename: $!";

#add(); Temporarily not used.

my @loop_data = ();  # initialize an array to hold your loop
my @keys = ();
my @values = ();

while ((my $key, my $value) = each my %hash) {
  push(@keys, $key);
  push(@values, $value);
}

while (@keys and @values) {
  my %row_data;
  
  $row_data{KEY} = shift @keys;
  $row_data{VALUE} = shift @values;

  push(@loop_data, \%row_data);
}

#delete(); Temporarily not used.
untie %hash;

$template->param(
    SHOW_ALL_LOOP => \@loop_data);

print $template->output;

sub add {
  my $key = time();
  my $record = $key;
  foreach my $field(@fields){
    $record  .= "\|$field";
  }
  $hash{$key}  = "$record";
}

sub delete {
  %hash = ();
}

[download]


And here is the HTML Template file for the code (news.tmpl): 

<html>
<head><title>News</title></head>
<body bgcolor=#eeeeee>
<center>

<TMPL_LOOP NAME="SHOW_ALL_LOOP">
  <table width=400 border=1 cellspacing=0 cellpadding=0>
  <tr><td valign=top bgcolor=#dddddd>
  <b>Key</b>:<TMPL_VAR NAME="KEY"><br>
  <b>Value</b>:<TMPL_VAR NAME="VALUE"><br><br>
  </td></tr>
  </table><br>
</TMPL_LOOP>

</center>
</body>
</html>

[download]


That should be all you need to check this program. By the way, this is not a homework question, this is a question that I would like to figure out how to do this sort of program correctly, because last summer I created a web framework news type of thing, but it sucked, and I am hoping this will be better overall than my last project. The old project's site page is at www.hashes.f2s.com ... but it is terrible ^_- so don't see it.

Andy Summers

In reply to How can I display DBM entries in an HTML table? (Revised) by bladx

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.