s/// does not untaint.

#!/usr/local/bin/perl -Tw

sub is_tainted {
    no warnings;
    no strict;
    return ! eval { join('',@_), kill 0; 1; };
}

[download]
# is_tainted() was taken from perlfaq7 
use strict;

my $site = <>;
chomp $site;
print is_tainted($site) ? "Tainted\n" : "Not tainted\n";

$site =~ s/[^-\@\w\/]//;
print is_tainted($site) ? "Tainted\n" : "Not tainted\n";

my $dir = "$sites_root/$site";
print is_tainted($dir)  ? "Tainted\n" : "Not tainted\n";

chdir($dir)
__END__
Tainted
Tainted
Tainted
Insecure dependency in chdir while running with -T switch at ./foo.pl 
+line 21, <> line 1.

[download]


So, untaint $sites with an m// and $1, according to perlsec:
my $validchars = 'A-Za-z0-9_.-';
if ( $site =~ /^([$validchars]+)$/o ) {
    $site = $1;
}else{
    warn "Invalid site: $site\n";
    next;
}

[download]

2;0 juerd@ouranos:~$ perl -e'undef christmas'
Segmentation fault
2;139 juerd@ouranos:~$

[download]

In reply to Re: -T taint mode & chdir by Juerd
in thread -T taint mode & chdir by mandog

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.