scalar( @$foo )-1
Use $#$foo instead, or $#{$foo}.
By the way, why not iterate over the array itself? for (@$foo) { do something with $_ }

my $i = my $aref = ();
You assign an empty list to two scalars, which isn't quite useful. Consider using just my ($i, $aref);. If you want $aref to be a reference to an empty array, use my $aref = [].

$aref = @$foo;
Makes no sense. This just assigns the number of elements in @$foo to $aref. You don't need a copy by the way. I suggest a rewrite of the loop: 
for (@$STF1){
    print OUTPUT "<li>$_->[0]</li>" .
                 qq{<a href="$_->[1]$STF3_Tables">$_->[2]</a><br />\n}
+;
}

[download]
Or a lot easier using printf: 
for (@STF1){
    printf OUTPUT "<li>%s</li>" .
                  qq{<a href="%s$STF3_Tables">%s</a><br />\n},
                  @$_;
}

[download]

You have a lot of temporary variables that aren't needed. 

# my @temp = foo; my $ref = [ @temp ];
my $ref = [ foo ];
# ($a, $b) = \(@a, @b); return $a, $b;
return \(@a, @b);

[download]

I personally dislike things like // and do { ... } and prefer a simple if (//) { ... }.

Hope this helps... 

2;0 juerd@ouranos:~$ perl -e'undef christmas'
Segmentation fault
2;139 juerd@ouranos:~$

[download]

In reply to Re: Critique / Suggestions? by Juerd
in thread Critique / Suggestions? by Sang

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.