Save yourself some regex complexity: use \d rather than [0-9], and you can also be more specific about the number of digits you expect. You should first extract the IP addresses (optionally with port numbers), and then try to separate them in a subsequent step. For example,

if ( $inLine =~ /
             (                 # $1 - first IP
             \d{1,3}           # 1-3 digits
             (?:               # grouping for rep count
                 \.            # dot
                 \d{1,3}       # 1-3 digits
             ){3}              # three more times
             (?:               # optional extra grouping
             \/                # a slash
             \d+               # 1st port number
             )?                # close extra grouping
             )                 # close group around 1st IP
             \s+               # whitespace
             \w+               # a word
             \s+               # more whitespace
             (                 # $2 - 2nd IP
             \d{1,3}           # 1-3 digits
             (?:               # grouping for rep count
                 \.            # dot
                 \d{1,3}       # 1-3 digits
             ){3}              # three more times
             (?:               # optional extra grouping
             \/                # a slash
             \d+               # 2nd port number
             )?                # close extra grouping
             )                 # close group around 2nd IP
           /x )                # specify /x
{
  # matched - now check for port numbers
  my @ips = ( $1, $2 );
  my @ports;

  foreach ( @ips ) {
    my ( $ip, $port ) split m{/};  # try to split IP on '/'
    push @ports, $port;            # may be undef
    $_ = $ip if $port;             # replace IP if got port
  }
}

[download]

dmm

If you GIVE a man a fish you feed him for a day
But, TEACH him to fish and you feed him for a lifetime

In reply to Re: Regex for IP and Optional Port by dmmiller2k
in thread Regex for IP and Optional Port by shockme

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.