If it is not a throw away script then you need to attempt at least some good programming practices.

In my experiance I've found that too many simple hacked together CGI scripts stay in production because a) they work and b) nobody has the time/money to fix them. The problem is that 6 months down the line somebody normally has to make a small change, which turns out to be another hack and so on and so forth.

Sometime you have to sit down and say, lets make this work properly and do it in a way that allows simple maintanance.

I have a big problem with embedded HTML in CGI scripts, I might be the one that has to maintain it and then I've got to spend ages trying to work out how it works.

Plus in his code he used the normal perl quoting which means he has to remember to put a \ in front of each quote which is a royal pain in the arse.

What's wrong with: 

use File::Basename;
$foo = basename($bar);

[download]
It's a hell of a lot more obvious what this does than your rexexp.

gav^

In reply to Re: Re: Re: CGI problem: trying to assign parameters in a loop by gav^
in thread CGI problem: trying to assign parameters in a loop by bighara

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.