Right off the bat, two lines look quite wrong. The "second stage",
where you read from the file, should look like
$visites = <hits>;
That's how you read from a file. The sixth stage, where you close
the file, should look like
close hits;
In addition, though, you should be:
- Checking for errors on filesystem calls (like open and close).
- Performing some sort of file locking.
- Turning warnings on (#!/usr/local/bin/perl -w)
- Using strict:
use strict;
These are good practices for any programmer. The second, file
locking, is especially important, because you could have more
than one person updating your hit counter file at the same time.
Thus you need file locking.
One of Randal Schwartz's Web Techniques columns focuses on file locking.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.