Hopefully this isn't offensive, but personally I'd rewrite your code as:
print "Enter file name and path of .ins to parse:\n";
my $filename1 = <STDIN>;
die "File $filename1 does not exist\n" unless (-e $filename1);

print "Enter file name and path of .rcs to search:\n";<br>
my $filename2 = <STDIN>;
die "File $filename2 does not exist\n" unless (-e $filename2);

open (FILE, "<$filename1) or die "Can't open file $filename1 :$!\n";
my @file = <FILE>;
close FILE;

foreach my $line (@file) {

[download]
Depending on what you're parsing here, I'd probably use a split rather than $1. YMMV.
ie: If file line was "EditorName Susan Hammel" I'd do
if ($line =~ /EditorName/) {
my @name = split(/\s+/, $line); 
my $first = $name[1]; 
my $last = $name[2];
}

foreach my $line2 (@file) { 
if ($line2 =~ /EditorCommand/) {
  my @commands = split(/s+/, $line2);
  shift @commands; # To remove the EditorCommand - Requires line that 
+looks like "EditorCommand print paste copy"
}

open (OUTPUT, ">>test.txt");

foreach my $com (@dcommands) {
  my $pattern = $word1 . ":" . $com;
  my $test = in_file($pattern, $filename2);
  if ($test) {
     print OUTPUT "Found $pattern in $filename2 \n";
  } else {
     print "$pattern not in $filename2 \n";
  }
}

exit;

#### SUBS ####

sub in_file {
  my $pattern = shift;
  my $filename2 = shift;

  open INFILE, $filename2 or die "Can't open $filename2: $!\n";
  my $found = 0;
  while (<INFILE>) {
     if (/$pattern/) {
        $found = 1;
         last;
     }
close FILE;
return $found;
}

[download]
HTH, YMMV
'Fect

In reply to Re: Re: Re: help needed on a foreach loop from hell!!! by Ineffectual
in thread help needed on a foreach loop from hell!!! by Kentdn

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.