i wrote a script a while back that received some comments from the monastery. one that kinda puzzled me, was a suggestion to replace repetition within variables with another variable. for example:

my %hash = ( a => "abcd1234", b=> "abcd5678");

[download]

this is just a short pattern and two instances. in my actual code, i think i had a longer pattern (abcdefghighkl) and probably ten instances. it was suggested that i should probably do something like:

my $prefix = "abcd";
my %hash = ( a=> $prefix . "1234", b => $prefix . "5678");

[download]

do i gain anything by extracting the repetition and placing it within its own variable? this would be adding a global, which i had thought should be something to avoid.

humbly -c

In reply to Is a global variable better than repetition within variables? by c

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.