Ok, here it goes, some points I noticed:

• You were not giving any parenthesis in your $find argument, so the $1 was not matching anything. I think this was the main thing that kept your attempt with eval from working.
• You were using double quotes for your "$1 " parameter, which was making it evaluate it at call time, so your subroutine never saw the $1, only a space.
• I tried enclosing the eval block in braces, but it does not work. I'm still a little bit puzzled about that.
• I'm sure the for loop can be done without the indexing, but I'm also sure you just did that as a quick hack, so I'm not going to try to correct it :-)

So the code below works:

print splitter($string,"<.*?>",'(\S{18})','$1 ');
sub splitter{
         my($string,$spliton,$find,$replace)=@_;
         my @array=split(/$spliton/,$string);
         my $i=0;
         my @splitters;
         my $str;
         while($string=~/($spliton)/g){
                 push @splitters,$1;
         }
         my $a;  
         for (@array){
         
                eval "s/$find/$replace/g; ";
                die "$@" if $@;
                $str.=$array[$i];
                $str.=$splitters[$i];
                $i++;
         }
         $str;
 }
[download]

I still think that eval'ing regular expressions in a quote block may be dangerous. But as long as you control the values of the expressions, it should be ok.

Hope this helps,

--ZZamboni

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.