Glad you posted this before I replied to the other, you've fixed this up well. There are still some warts, though.

  1. Don't use $a and $b for scratch variables; they are sacred to sort.
  2. Lock your files or use a locked semaphore file. You have races if more than one instance of this runs (e.g. if it is fired by suspicious tcp connections)
  3. When you die, put $! in die's argument list (without any "\n"). That will give you diagnostics you might not get otherwise.
  4. grep can clean up your last while loop, and maybe help the logic, too.
  5. use strict; use warnings;
  6. Take a look at the &Digest::MD5::addfile(\*HANDLE) method
  7. It will take O(N2) to compare all those digests the way you do it. How about making a hash with the digest as key, and checking for existance in the hash?
You can turn this into a thing of beauty. Good luck, and have fun.

After Compline,
Zaxo

In reply to Re: Log's and MD5 Hashes -- FINALLY DONE by Zaxo
in thread Log's and MD5 Hashes by satanklawz

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.