It might be faster and more accurate if $count was derived from keys %sites instead of incrementing it. This is especially true if some $siteid is not unique.

$count=0;
$sth->bind_columns(\($siteid, $imageurl));
while($sth->fetch()) {
 $sites{$siteid}=$imageurl;
 $count++;
}

[download]
Would become:
$sth->bind_columns(\($siteid, $imageurl));
while($sth->fetch()) {
    $sites{$siteid} = $imageurl;
}
$count = keys %sites;

[download]

$flag, $type, and $size don't have to be file scoped. If you reverse the logic of $flag and change its name to $error, the foreach block becomes easier to read.

my $error = 1;
if ( my($type, $size) = ( head($imageurl) )[0, 1] ) {
    if ($size < 25600) {
        if($type =~ /image\/(gif|jpeg)/) {
            print "OK ($size bytes, $type)\n";
            $error = 0;
        } else {
            print "Wrong file type ($type, must be image/gif or image/
+jpeg)\n";
        }
    } else {
        print "Image size exceeded ($size bytes, should be < 25600)\n"
+;
    }
} else {
    print "Error\n";
}

if ( $error ) {
    print FILE "update big_ass_table set imagedown=imagedown+1 where s
+iteid=$siteid and imageurl='$imageurl';\n";
} else {
    print FILE "update big_ass_table set imagedown=0 where siteid=$sit
+eid and imageurl='$imageurl';\n";
}

[download]



HTH,
Charles K. Clarkson
Clarkson Energy Homes, Inc.
254 968-8328

In reply to Re: URLs' Checking (Search Engines) by CharlesClarkson
in thread URLs' Checking (Search Engines) by nikos

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.