A few short points:

  • You can create a hash ref like this: 
    $hr = { x => 1, y => 2 };

    [download]

  • Don't use 
    $$dbHash{connect}->prepare("$sql")

    [download]
    when 
    $db->{connect}->prepare($sql)

    [download]
    is so much cleaner

  • Using: 
    $str = join(',', ('?') x @{$row->[0]}))

    [download]
    seems cleaner to me than 
    $str = join (",",map {"?"}(0..$#{$rowRefs->[0]})

    [download]

  • I like to call my statement handles $sth so I can remember what they are ($sth_insert, $sth_delete, etc if I need multiple ones).

  • why the main()? ... this isn't C :)

  • personally I don't like your functions that make the DBI calls (dbConnect & getData), they just seem to complicate things

  • Also this doesn't add any value than using mysqldump which has a lot more useful options.

    Hope this helps...

    gav^

    In reply to Re: dbCopy.pl by gav^
    in thread dbCopy.pl by abaxaba

    Title:
    Use:  <p> text here (a paragraph) </p>
    and:  <code> code here </code>
    to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.