1. I would use values instead of referencing keys repeatedly. I have no idea if this is any faster. Anyone?
    (Update: Well, if japhy agrees, that's good enough for me...)
  2. I would do the date test before looping through the Messages.
  3. I'd use grep instead of what you have, but probably for no good reason. If it's appropriate, looping through Messages can be further improved by making it break out early when a match is found... 
open(RPT,">$DIR/$RPT")||die"Can't open $RPT: $!\n";
print RPT "Report Date: $month/$day/$year\n";
print RPT "$RPT\n";
print RPT "============================\n";
foreach my $value (values %hash) {
   next unless $value->{date} =~ $DATE;
   next unless grep { $value->{error_message} =~ /$_/ } @Messages;
   print RPT ... 
   ...
}
close RPT;

[download]

buckaduck

In reply to Re: How could I make this code more optimized by buckaduck
in thread How could I make this code more optimized by TStanley

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.