Well, this won't necessarily make it faster, but it'll be a lot easier to read. Create a reference to $hash{$key} and use that instead: (note, untested)

my ($key, $msg, $ref); # stick with the naming convention ;-) foreach $key (keys %hash) { $ref = \$hash{$key}; foreach $msg (@Messages) { if ($ref->{error_message} =~ /$msg/ and $ref->{date} =~ $DATE) { # # Notice one print call will suffice, # just line up what you want to print, # or concatenate into a single string. # print RPT "$ref->{packet_id}\t$ref->{origin}\n", "$ref->{date}\t$ref->{qualifier}\n", # etc.
Another thing: you don't show what's in @Messages or $DATE. If either of those are constant strings, don't bother with a pattern match at all; use string comparison.

HTH


In reply to Re: How could I make this code more optimized by VSarkiss
in thread How could I make this code more optimized by TStanley

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.