Wouldn't having a wait() inside the loop make the code execute as if it wasn't forking? consider this simplified version of your script: 

## simplified code, so no error checking...
foreach my $node (@devices) {
   my $pid = fork();
   if( !$pid ) {
      ## child...
      exit 0;
   }
   ## parent
   wait();
}

[download]

So this means that for each node, you fork off a process, and immediately afterwards the parent waits for that process. The parent will block until the child is done. Thus no merit of forking here...

You need to do something like this:


use POSIX;
$SIG{CHLD} = sub {
    while( ( my $pid = waitpid(-1, POSIX::WNOHANG()) ) > 0 ){
        ## cleanup code...
        ## you probably should save the forked
        ## pids and make sure that the result of
        ## waitpid is indeed your child
    }
}

foreach my $nod ( @devices ) {
   my $pid = fork();
   if( !$pid ) {
      ## child...
   }
}

[download]

Now, as for your switching needs, I might do something like this:

use POSIX;
my $do_fork = 1;
$SIG{CHLD} = sub {
    while( ( my $pid = waitpid(-1, POSIX::WNOHANG()) ) > 0 ){
        ...
    }
}

foreach my $node ( @devices ) {
    if( $do_fork ) {
        my $pid = fork();
        if( !$pid ) {
            do_exciting_things();
            exit 0;
        }
    } else {
        do_exciting_things();
    }
}

[download]

This is obviously just a psuedocode, so make sure to put plenty more error checking and all that stuff.

In reply to Re: making fork() a flag, and wait()ing properly by lestrrat
in thread making fork() a flag, and wait()ing properly by c

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.