a couple of things,

The major problem with the code you have there is that it doesn't give combinations of separated list items, it only gives items from one point forward. As an example:
for n=3, with items 1,2, and 3, i get the following from your code:
1
1 2
1 2 3
2
2 3
3
Note the missing '1 3' case. For the items 1,2,3, and 4, '134', '124', '13', '14', etc would be missing.

Merlyn's snippets are a nice and easy way to go; a simple transformation and they will return an array of strings instead of an AoA. As an exercise, i chalked up a non-recursive solution as well; it returns an array of arrays as merlyn's does.

sub combinations {
  my (@comb, $pos);
  my $limit = 2**@_;

  while (my $item = shift) {
    my $step = 2**@_;
    for ($pos = 0; $pos < $limit; $pos += $step) {
      push @{$comb[$pos++]}, $item for 1..$step;
    }
  }

  return @comb, [];
}
[download]

jynx

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.