Hi

I've written the below sub to check all URLs in my database and return a error message for each individual URL if the status code returned is not 200.

The sub works, but is slow. I've got 20 entries in my database at the moment, and the following sub takes just over 11 seconds to check all 20 entires.

Does anyone know of a (much) faster way of doing this? Is LWP::UserAgent the way to go, or is the way I'm accessing my MySQL slow?

Would selecting url from database be a lot faster than selecting * (all fields)? Should I get all results first into an array or hash and then output them instead of outputting one by one?

Thanks for any help you can give me! 

    use LWP::UserAgent;
 
    $ua = new LWP::UserAgent;
    $ua->agent("OpticDB LinkCheck/0.1");
 
    &connect_to_db;
 
    my $clock_start = time; # start timer
 
    $sth = $dbh->prepare("SELECT * FROM $DB_MYSQL_NAME");
    $sth->execute ();
 
    my $count = 0;
 
    while (my $ref = $sth->fetchrow_hashref ())
    {
 
        my $req = new HTTP::Request GET => $ref->{'url_en'};
        my $res = $ua->request($req);
 
            $res_id   = $ref->{id};
            $res_code = $res->code;
            $res_msg  = $res->message;
 
            unless ($res_code eq "200") {
             
                $count ++;
 
                $tmpl_show_record .=  qq|
 
                .. html to show erroneous records goes here ...
                |;
            }
    }
 
    $num_dead = $count;
 
    if ($count == 0) {
        &error_html("No dead links found!");
        exit;
    }
 
    $sth->finish();
 
    my $clock_finish = time - $clock_start; 
    $time_taken = sprintf ("%.2f", $clock_finish); 
 
    $dbh->disconnect;

[download]
--
Wiliam Stephens <wil@stephens.org>

In reply to Checking links with LWP::UserAgent by wilstephens

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.