Hi, Trying to create a little script that can be set up easily for use again and again for checking submitted Form Data. This works, but I just wanted to know if theres anything I could make more efficient?
#!/usr/bin/perl use CGI; use strict; my $q = new CGI; print "Content-type: text/html\n\n"; #GET VARIABLES FROM SUBMITTED FORM ############################################ my %form = (var1 => $q->param('var1'), var2 => $q->param('var2'), var3 => $q->param('var3')); #SET ARRAY WITH REQUIRED FIELDS ############################################ @reqform = (var1,var2,var3); #CHECK THAT REQUIRED FIELDS FILLED else PRINT ERROR ################################################### foreach (@reqform) { if ($form{$_} eq '') {@errormsg = (@errormsg, $_);} } if(@errormsg) { &PrintError;} else {&CARRY_ON_PROCESSING_FORM; } #PRINT ERROR ################################################### sub PrintError { print "<html><body>"; foreach (@errormsg) { print "You need to enter something for <b>$_</b><br>"; } }
ThAtH0M

In reply to Checking Submitted Form Data by Thathom

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.