A couple of other things could maybe be improved upon in terms of using more "natural" perlish syntax (and of course it always helps to use strict; use warnings;):

For instance, I'd change:

$fHandle = CGI::->new(); $fCounter = 0; while ($fCounter <= 4) { $fBuffer[$fCounter] = fHandle->param($fName[$fCounter]); $fCounter = $fCounter + 1; }
to
$fHandle = CGI->new(); # note you don't need the colons for (0..4) { $fBuffer[$_] = $fHandle->param($fName[$_]); }

And why use goto when a subroutine would probably be more natural? Obviously I don't know what each section does but I would suspect that a sub could be a better answer... so I'd consider changing:

if ($fBuffer[0] ne "Proccess") {goto BadAccess} if (length($fBuffer[1]) < 1) {goto BadAccess} if (length($fBuffer[2]) < 1) {goto BadAccess} if ($fBuffer[3] ne "thread2") {goto BadAccess}
etc. with the following:
BadAccess() if ( $Buffer[0] ne "Process" or length $fBuffer[1] < 1 or length $fBuffer[2] < 1 or $fBuffer[3] ne "thread2" );
etc.

Also, I can't help but wonder if using hashes might provide a more readable solution than using an array and referring to the properties you are expecting by number...

These are just suggestions... as everyone knows There's More Than One Way To Do It but everytime a monk has given me a suggestion it's proven invaluable to study it even if I don't end up doing things exactly as suggested! Hope it helps.

..Guv


In reply to Re: combined text&files by theguvnor
in thread combined text&files by PriNet

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.