I think this will work. You will find that using placeholders (the "?" in the $query statement) will make your DBI programming life much easier.

It may not look much shorter than yours, but it's infinitely more scalable.

-fuzzyping
my %rent_hash = (Y=>["Yes",undef], N=>["No",undef]);
my $query = "SELECT COUNT(*) FROM owner WHERE rent_car = ?";
my $sth = $dbh->prepare($query);
foreach (keys %rent_hash) {
        $sth->execute($_);
        my $rent_hash{$_}[1] = $sth->fetchrow_array();
        my $rent_carno += $rent_hash{$_}[1];
        my $percent = (($rent_car{$_}[1] / $result) * 100);
        printf qq(<tr><td>$rent_hash{$_}[0]</td><td>$rent_car{$_}[1]</
+td><td align="right">%.2f%%</td></tr>\n),$percent;
}

my $rent_carnor = $result - $rent_carno;
my $percent_total = (($rent_carnor / $result) * 100);
printf qq(<tr><td>No Response</td><td>$rent_carnor</td><td align="righ
+t">%.2f%%</td></tr>\n),$percent_total;

[download]

In reply to Re: Perl - MySQL query question by fuzzyping
in thread Perl - MySQL query question by peppiv

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.