Dear monks,

I have just written a little function that translates a network mask in /xx notation to a network mask in xx.xx.xx.xx notation. My code follows :
# This function takes a number in paramater (eg 24) and
# returns the corresponding mask in longer format 
# (eg 255.255.0.0)

sub mask_short_to_long
{
        my $short_mask = shift;
        my ($bin, $num, @mask);

        $bin = "1" x $short_mask . "0" x (32 - $short_mask);

        for my $i (0..31) {
                $num += substr($bin,31 - $i,1) * (2 ** $i);
        }

        for my $i (0..3) {
                unshift @mask, (($num >> ($i * 8)) & 0xFF);
        }
        return join('.',@mask);
}

[download]
But I just feel something more elegant and shorter could be done.

Any idea to improve it?

Any one-liner? ;))

Zejames

In reply to Shorter code ? by zejames

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.