First, I'd like to commend you for trying to figure out how to use strict. And, yes, the problem is one of scoping.

There are two solutions, one better than the other.

  1. Put a my $yesterday; outside of the if clause. Then, it's just $yesterday = &read_benchmark();. This is creating a global variable. Acceptable, but not very scalable.
  2. The better solution is to pass $yesterday into print_report(). You'd do it something like this: 
        my $yesterday = &read_benchmark();
...
    &print_report($yesterday);
...
sub print_report {
    my ($yesterday) = @_;
# Rest of function the same.
}

    [download]
    This is considered better because you could then re-use the print_report() function with some other script and it wouldn't depend on $yesterday being declared for it.

------
We are the carpenters and bricklayers of the Information Age.

Don't go borrowing trouble. For programmers, this means Worry only about what you need to implement.

In reply to Re: Problem Declaring Variable by dragonchild
in thread Problem Declaring Variable by PrimeLord

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.