hakkr,

I'm not sure why you're currently getting error messages, maybe something else is overwriting dbh. But I am concerned about your lack of error checking and your use of prepare (and if this was just a stripped down example, much apologies). 

my $dbh = $self->param('dbh') or carp "dbh is not behaving\n";
...
$sth->execute() or carp "problems executing ...\n"

[download]

note bad code showing use of "do" vice prepare deleted - it was just wrong but you probably should try prepare_cached and bind_params. 

my $query = "SELECT id FROM table WHERE user = ?";
my $results=$self->query($query, $user )->fetchrow_array;

sub query {
    # Do database query
    my($self, $sql, $val ) = @_;
    
    my $dbh=$self->param('dbh') or die "what's up with dbh?\n";
    my $sth = $dbh->prepare_cached( $sql );
    $sth->execute( $val );
    return $sth;
}

[download]

But maybe I'm all wet and you were just showing a snippet.

-derby Update: nevermind that whole "do" thingy - that only works on non-SELECT sql. drats.

In reply to Re: Best way to call DBI query by derby
in thread Best way to call DBI query by hakkr

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.