OK... Here's some suggestions.

#!/usr/local/bin/perl
Turn on Taint checking, warnings and strict.
#!/usr/local/bin/perl -wT use strict;


for your header you can use the CGI.pm

CHANGE
&html_header("It's been sent");
TO
use CGI; my $q = new CGI; print $q->header;


Not that it matters much in a script this small, but I would point you to Template Toolkit to seperate you markup from your code. Then you can replace all these print statments.

print "<H2 ALIGN=center>It's been sent!</H2>; print "<HR ALIGN=center>"; print "<IMG SRC=\"http://www.iupui.edu/~webtrain/Graphics/Photos/b +ora_bora.jpg\>"; ...

Here it looks like you're getting the query string. You can use CGI's param method.



CHANGE
@pairs = &url_decode(split(/[&]/, $request)); while ($pairs[$r]) { ($a,$b) = split(/[=]/,$pairs[$r++]); ($name = $b) if ($a eq 'name'); ($email = $b) if ($a eq 'email'); ...
TO
$q->param('name') $q->param('email') ...

And as merlyn pointed out this is really bad

open (MAIL, "|  mailx -s \"Web mail from $email!\" cholling\@iupui.edu");

but when you turn on Taint checking this will not be allowed. This does not mean Taint checking is the be all, end all, you can unsafely untaint data. I would highly recommend Ovid Web programming with Perl course.

grep
grep> cd /pub
grep> more beer


In reply to Re: use CGI.pm by grep
in thread porting a script from cgi_handlers.pl to CGI.pm (was : use CGI.pm) by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.