Hi Monks. Consider this slice of code:


# (...)
sub indexfiles {
    my $cod  = $_[0] || die $!;
    my $root = $_[1] || '.';
    # XXX how to correct this?
    our @files;

    find(\&wanted, $root);
    sub wanted 
    {
        push(@files, $_) if /\.mp3$/;
    }

    open(DB, "> $dbpath/$cod.txt") || die $!;
    foreach(sort @files)
    {
        s/\.mp3$//;
        print DB $_, "\n";
    }
    close(DB);
}
# (...)

[download]

In my habitual novice ignorance I tried to change the code a few times to look mode elegant. I don't like a sub inside another sub. And declaring a variable like that with our scares me, and possibly all you. :)

How to handle that with correctness, without mess the code and handle properly the @files array context?

Hoping that it wouldn't be too stupid... -- zjunior

In reply to Using File::Find with a bit of elegance by zjunior

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.