I've written a simple cgi script that generates the company phone list from a sql backend. I'm looking for some advice on simplifing this branch structure. There is a strong pattern here and I can think of a few simple ways to reduce the code but I wanted to see what other people would do to make this more managable.
if ($type eq 'f') { if ($ref->{'pic'}) { print $q->Tr([ $q->td({-bgcolor=>$cellcolor},[$q->a({href=>"$ +ref->{'pic'}"},$ref->{'name'}),$ref->{'phone'},$ref->{'fax'},$ref->{' +loc'}, $q->a({href=>"mailto:$ref->{'email'}"},$ref->{ +'email'}) ]) ]); } else { print $q->Tr([ $q->td({-bgcolor=>$cellcolor},["<LI>".$ref->{' +name'},$ref->{'phone'},$ref->{'fax'},$ref->{'loc'}, $q->a({href=>"mailto:$ref->{'email'}"},$ref->{ +'email'}) ]) ]); } } elsif ($type eq 'c') { if ($ref->{'pic'}) { print $q->Tr([ $q->td({-bgcolor=>$cellcolor},[$q->a({href=>"$ +ref->{'pic'}"},$ref->{'name'}),$ref->{'phone'},$ref->{'fax'},$ref->{' +loc'}, $ref->{'con'}]) ]); } else { print $q->Tr([ $q->td({-bgcolor=>$cellcolor},["<LI>".$ref->{' +name'},$ref->{'phone'},$ref->{'fax'},$ref->{'loc'}, $ref->{'con'}]) ]); } } else { if ($ref->{'pic'}) { print $q->Tr([ $q->td({-bgcolor=>$cellcolor},["<IMG SRC=\"/im +ages/thumb_$ref->{'pic'}\">&nbsp &nbsp".$q->a({href=>"/images/$ref->{ +'pic'}"},$ref->{'name'}),$ref->{'phone'},$ref->{'cell'},$ref->{'loc'} +, $q->a({href=>"mailto:$ref->{'email'}"},$ref->{ +'email'}) ]) ]); } else { print $q->Tr([ $q->td({-bgcolor=>$cellcolor},['<LI>&nbsp &nbs +p '.$ref->{'name'},$ref->{'phone'},$ref->{'cell'},$ref->{'loc'}, $q->a({href=>"mailto:$ref->{'email'}"},$ref->{ +'email'}) ]) ]); } }

In reply to Simplifying repetitive flow structures by Dogma

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.