Please do not use this ptime.pl It's rather ugly perl4 code in the first place, and you only call it in one place -- and in that case (&ctime(time)) it's equivilent to scalar localtime Except that scalar localtime doesn't have any of the bugs. ;>

There are only two other things which stick out at me, both of them at least partially stylistic. For one, variables start off being undefined so the = undef part of

my ($foo, $bar, @baz) = undef
is repetitive. The only other note is that the code could be made slightly tighter by scoping the variables a little tighter. For instance, both $drive and $computer can be scoped just to the loop they're used in:
foreach my $computer (@computerlist) { ... # yadda yadda yadda foreach my $drive (@drives) { ... } ... }

Other than those couple of nitpicks, the code looks to be rather handy.

perl -pe '"I lo*`+$^X$\"$]!$/"=~m%(.*)%s;$_=$1;y^`+*^e v^#$&V"+@( NO CARRIER'


In reply to Re: Domain Disk space check by Chmrr
in thread Domain Disk space check by Marza

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.