Well, there's the usual part about use strict. If you are using strict, then you're declaring these variables outside of your subroutine. From the way you have the last two lines of the subroutine, it appears to me that you are setting global variables and having other subs rely on them. This is difficult because it can be a problem telling where a variable is initialized, changed, or reused.

I can't tell from your code where the problem is (am I missing something simple?), but you can simplify some stuff:

$sth = $dbh->prepare("DELETE FROM $holding_table WHERE year=? AND
month=? AND day=? AND time_start=? AND time_end=? AND title=?");
$sth->bind_param(1, "$key[1]");
$sth->bind_param(2, "$key[2]");
$sth->bind_param(3, "$key[3]");
$sth->bind_param(4, "$key[4]");
$sth->bind_param(5, "$key[5]");
$sth->bind_param(6, "$key[6]");
$sth->execute();
[download]

That can become:

$sth = $dbh->prepare("DELETE FROM $holding_table WHERE year=? AND
month=? AND day=? AND time_start=? AND time_end=? AND title=?");
$sth->execute( @key );
[download]

Questions:

• Do you set the RaiseError flag when you instantiate the DBI object?
• Are you sure that your values from the split are correct? You're splitting on a comma and an extra comma could make life difficult.
• Have you tried printing out all of the @key values and creating the SQL by hand? If even one of your values does not match a value in the database, the SQL will fail.

Cheers,
Ovid

Join the Perlmonks Setiathome Group or just click on the the link and check out our stats.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.