Style issues.

A couple of things that you probably want to keep in mind while coding. First, if you won't use strict, at least be sure to lexically scope your variables by declaring them with my. For example, in your &passhash method, you don't declare your hash, thus making it a package variable and you lose encapsulation.

• Whenever you are doing OO programming, remember that the first argument to the method is the object.
• Be sure to use proper (or at least consisten) indenting to indicate scope.
• Your constructor should use the two-argument form of bless. Otherwise, you can't inherit from this.

package packa;
use strict;

sub new {
    my $class = shift;
    my $self = {};
    bless $self, $class;
    return $self;
}

sub pass{
    my ( $self, $problem1 )= @_;
    print "$problem1\n";
}

sub passhash{
    my %hash = qw {
        dog voa
        cat mice
    };
    $hash{'problem2'} = [
        ["ha" , "thing", "thorw"], 
        ["good", "ssa" , "ham"],
        ["as", "kid", "wo"],
    ];
    return %hash;
}
[download]

Hope this helps.

Cheers,
Ovid

Join the Perlmonks Setiathome Group or just click on the the link and check out our stats.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.