Just a style suggestion. Using whitespace doesn't slow Perl down, but speeds up reading a script, because it makes things more clear.

You now have:

# Variables: my $pagetitle; # page's title my $author; # author's name my $copyright_holder; # the copyright holder my $chartset; # character set # Does $chartset have to be the same as # $encoding in page_specs? my $default_keywords; my $default_description; # Variable defaults: $pagetitle="PUT-YOUR-TITLE-HERE"; $author="mynamehere"; $copyright_holder=$author; $chartset="iso-8859-1"; $default_keywords=""; $default_description="";
While I think the following is clearer:
# Variables: my $pagetitle; # page's title my $author; # author's name my $copyright_holder; # the copyright holder my $chartset; # character set # Does $chartset have to be the # same as $encoding in page_spec +s? my $default_keywords; my $default_description; # Variable defaults: $pagetitle = "PUT-YOUR-TITLE-HERE"; $author = "mynamehere"; $copyright_holder = $author; $chartset = "iso-8859-1"; $default_keywords = ""; $default_description = "";
You first use my, and then assign. You can have an assignment directly after my:
my $pagetitle = "PUT-YOUR-TITLE-HERE";
Making the names shorter and using a hash can also help a lot:
my %hash = ( title => 'PUT-YOUR-TITLE-HERE', author => 'mynamehere', copyright => 'mynamehere', charset => 'iso-8859-1', keywords => '', description => '' ) # hash values can be accessed as $hash{title} etc.

- Yes, I reinvent wheels.
- Spam: Visit eurotraQ.


In reply to Re: Making a 'blank' xhtml page - request for comments by Juerd
in thread Making a 'blank' xhtml page - request for comments by func

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.