I am trying to make jpeg image thumbnails with GD, not Image::Magick.
I found the following code below here, but I can't get it to work right
Sometimes I get errors, and sometimes it works, when it does work,
the thumbnail only slightly resmebles the source file.

What is going wrong?

-thanks in advance,
silent11 
#! perl -w
use GD;

my $source = 'meat.jpg';
my $Thumbnail = 'thumb_' . "$source";

my $maxheight = 150;
my $maxwidth = 150;
my $srcimage = GD::Image->newFromJpeg("$source");
my ($srcW,$srcH) = $srcimage->getBounds();
my $wdiff = $srcW - $maxwidth;
my $hdiff = $srcH - $maxheight;
my $newH; my $newW;

if ($wdiff > $hdiff) {
      $newW = $maxwidth;
      $aspect = ($newW/$srcW);
      $newH = int($srcH * $aspect);
  } else {
      $newH = $maxheight;
      $aspect = ($newH/$srcH);
      $newW = int($srcW * $aspect);
 }

  print "converting $srcW:$srcH to $newW:$newH\n";

  my $newimage = new GD::Image($newW,$newH);
  $newimage->copyResized($srcimage,0,0,0,0,$newW,$newH,$srcW,$srcH);
open(FILE, ">$Thumbnail") || die "Cannot open $Thumbnail : $!\n";
print FILE $newimage->jpeg;

[download]

In reply to GD thumbnail script errors by silent11

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.