Here are some suggestions.

You are not testing the success of your open calls, and as they are in fact pipes, they are, in my experience, more prone to failure than regular files. To make matters worse, you are relying (hoping) that a program named 'mail' in somewhere on your PATH when the script is run. (But which one)? Not to mention trickier things like Net::Telnet objects.

Your firewalls could roll belly up, and you wouldn't even know about it... Always always always check the results of system calls.

Other minor issue: you should initialise an array with my @errors = (), not with my @errors = "". That said, it is a laudable practice to explicitly initialise variables. I find things are a lot clearer when spelt out:

  my $widget = undef;
  while( <> ) {
    if( useable($_) ) {
       $widget = $_;
       last;
    }
  }
  if( defined $widget ) { ... }
[download]

The undef and subsequent defined form a pair. It makes it easy to see that the purpose of the loop is to get $widget out of the undefined state. Hmm, but I digress :)

Don't do things like $availablefirewall = "$backupfirewall". Omit needless string interpolation.

It's poor practice to munge arrays passed to subroutines. You call Notify() so:

  Notify ($key, $script, @errors, @message);
[download]

And retrieve the parameters in Notify() thusly:

  my $key = shift @_;
  my $script = shift @_;
  my $errors = "@_";
[download]

Someone else reading this code may puzzle for a while wondering where the fourth parameter disappeared to. Merge the arrays explicitly before passing them, or pass them by reference. Also, when you my $errors = "@_"; it's good practice to precede it with a local $" = ' '; It's a habit that will prevent you from shooting yourself in the foot in the future.

print@_{sort keys %_},$/if%_=split//,'= & *a?b:e\f/h^h!j+n,o@o;r$s-t%t#u'

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.