Some pointers:

• Use better variable names, things like $trf, $trft etc are too easy to confuse
• Use different quotes (look up the qq// operator) so you don't have to escape quotes all the time
• Better yet, use something like HTML::Template (or any other templating module) so you don't have to embed HTML in your scripts
• If something is a number, treat it like a number. Use $months == 2 instead of $months eq "2"
• Make sure the plurality of the variable name is right, eg $month instead of $months
• Use my and stop using global variables

Replace code like:

    while (@dataf = $sthf->fetchrow_array())
    {
        $filiais[$xf] = $dataf[0];
        $xf++;
    }
[download]

with calls that use selectall_arrayref. Use bind so you can write:

$sth->execute;
$sth->bind_columns(\my $x, \my $y);
while ($sth->fetch) {
   # use $x and #y
}
[download]

Use placeholders to save issues with quoting:

my $sth = $dbh->prepare('select w from x where y = ? and z = ?');
$sth->execute($y, $z);
[download]

You've also got quite a bit of code that looks repeated. Maybe you can refactor it out into some loops or subroutine calls. You should try to make functions shorter in length so that it's easier to comprehend and you don't have to keep scrolling up and down so much.

That's all for now...

gav^

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.