I guess the real question is... what are you using this for... you could be more efficient by waiting till you need a set of substrings, then generating and caching all the 3 letter substrs when you need a 3 letter substr... but that only works for certain situations...

or you could have better space efficiency by keeping a list of offsets in an array, each index indicating the substring length... like so... 

foreach my $length (1..length($string)) {
  foreach my $offset (0..length($string)-$length) {
#    push @result,substr($string,$offset,$length);
     push @{$result[$length]}, $offset;
  }
}

[download]
Untested, but now @result should hold lists of offsets, with the primary index being the length of the substr... which uses much less space...

really there are endless possibilities... so how can you narrow it down?

                - Ant
                - Some of my best work - (1 2 3)

In reply to Re: Finding all substrings by suaveant
in thread Finding all substrings by TheHobbit

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.