Actually it makes it ever so slightly slower, much to my surprise :-/ 
use Benchmark qw(cmpthese);

sub substrings_TheHobbit {
  my $string = shift;
  my @result = ();

  foreach my $length (1..length($string)) {
    foreach my $offset (0..length($string)-$length) {
      push @result,substr($string,$offset,$length);
    }
  }
  return @result;
}

sub substrings_thelenm {
  my $string = shift;
  my @result = ();
  my $strlen = length $string;

  foreach my $length (1..$strlen) {
    foreach my $offset (0..$strlen-$length) {
      push @result, substr($string,$offset,$length);
    }
  }
  return @result;
}


cmpthese(-10, {
    TheHobbit   => sub { substrings_TheHobbit("Just Another Perl Hacke
+r,") },
    thelenm     => sub { substrings_thelenm("Just Another Perl Hacker,
+") },
});

__output__

Benchmark: running TheHobbit, thelenm, each for at least 10 CPU second
+s...
 TheHobbit: 12 wallclock secs (10.51 usr +  0.03 sys = 10.54 CPU) @ 80
+4.55/s (n=8480)
   thelenm: 14 wallclock secs (10.44 usr +  0.02 sys = 10.46 CPU) @ 80
+9.37/s (n=8466)
           Rate TheHobbit   thelenm
TheHobbit 805/s        --       -1%
thelenm   809/s        1%        --

[download]
Is there any reason why a function call would be quicker accessing a lexical variable?
_________
broquaint

In reply to Re: Re: Finding all substrings by broquaint
in thread Finding all substrings by TheHobbit

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.