There are several problems with your code... As mdillon already
pointed out you should chomp $input to remove the
cr/lf. The other major error is in the following line:
print "${line}";
That should read $line and not ${line}.
Now I've fixed your code (you can see my fixes below) to make it
functional, but it still isn't very "perl" looking and has
some needless code.
#!/usr/bin/perl
my $ans;
my $currentline;
my @data;
print "Letter? ";
$letter = <STDIN>;
chomp $letter;
open (DATA, "books.txt");
@data = <DATA>;
$currentline = 0;
foreach $data(@data) {
$line = $data[$currentline]; # there are brackets around $cu
+rrentline
if ($line =~ /^$letter/i) {
print $line;
}
$currentline++
}
Now here is a much more "perl-looking" implementation:
#!/usr/bin/perl -w
use strict;
print "Letter? ";
my $letter = <STDIN>;
chomp $letter;
open (DATA, "books.txt") or die "error opening file $!";
my $line;
foreach $line(<DATA>) {
if ($line =~ /^$letter/i) {
print $line;
}
}
close DATA;
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.