In node this node ovid very kindly points out a couple of my silly mistakes. He corrects my code and offers another clearer sub. Ingrate that I am, I'm not sure the new sub is acutally clearer....: 
sub Ovid_Clear_MakePtag{
  my $fixme = shift;           # take in our parameters
  return join "\r\n",          # join with newlines
    map  { "<p>$_</p>" }       # wrap each line in <p></p> tags
    grep { /\S/ }              # must have at least one non-whitespace
+ character
    split "\r\n", $fixme;      # break apart on the newlines
}
sub MakePtag{
  chomp(my $fixme = shift;)    # take in our parameters
  $fixme=~s|(\r\n)|</p><p>|g;  # replace all \r\n with <\p><p>
  $fixme = "<p>$fixme</p>";    # Add beginning and ending tags
  return $fixme;               
}

[download]

In the new version there are 6 concepts to understand (shift,join, map,split, comments within an expression, return) 5 lines and one relatively long expression.

In the old version, there are 5 concepts (shift,chomp,s///, interpolation, return) and four lines with four pretty simple expressions.

Part of the issue is that I'm more familar w/ the original 5 concepts than ovid's new ones. However, I'm guessing that most people find it easier to read several short expressions instead of one long one...

Am I missing something here?



email: mandog

In reply to What is clear code ? by mandog

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.