It looks like Perl, but it's heavily accented. Consider:
while (<BPCONF>)
{
my ($server) = unpack ("@10 A10", $_);
if (($server eq "SERVER = cluster") && ($ps ne "daemon"))
{
print "Server entry is correct\n";
exit (110);
}
else
{
print "Server entry is incorrect\n";
exit (100);
}
}
Notes on the changes:
- ${ps} is the same as $ps. The braces are used when you are trying to specify where the variable stops and other data starts. "$psfoo" references $psfoo, not $ps like "${ps}foo" would.
- That is some truly bizarre indentation.
- A single equals makes an assignment, not a comparison. A standard comparision is eq which tests for string equivalence. == tests for numerical equivalence.
- The while{} block does not require to be terminated with a semicolon. You can put one there if you like, but it is functionally useless.
- You are comparing against $_ and not your extracted $server variable.
- $ps must be defined somewhere else in your code.
- Instead of using unpack you might want to use a regular expression, or perhaps substr.
Other than that, make sure you
use strict and
-w.
Here's a few ways to get your
$server value, all pretty much equivalent:
my $server = substr($_, 10, 10);
my ($server) = /^.{10}(.{10})/;
Using a regular expression is generally better, especially if you're not sure precisely where the data is going to be, index wise. If you were looking for "SERVER", your code might resemble this:
while (<BPCONF>)
{
if (/SERVER = cluster/ && $ps eq "daemon")
{
print "Server entry is correct\n";
exit (110);
}
else
{
print "Server entry is incorrect\n";
exit (100);
}
}
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.