comment on

Thanks for your feedback Neil - A couple of quick comments ...

In the reporting loop, the conversion of scalar to numeric can be performed more directly with $_ + 0 instead of the sequential increment and decrement.

In a quick test of your code, it didn't appear to correctly validate the parameter passed on the command line - No error messages were returned when using an out of bounds value.

In the original snippet of code which I posted, I consciously made use of the Filesys::Df module for the determination of disk space in place of parsing the output of df.
The reason for this stems from my near paranoid nature about making external system calls - Introducing an external system call places an additional dependency upon the code to run and introduces a point in the system where the code may either fail or be compromised. If you must perform system calls, ensure that the full path to the application is given and that system return codes are checked - Also see my discussion on this here

In reply to Re: Re: dfmon - Disk Free Monitor by rob_au
in thread dfmon - Disk Free Monitor by rob_au

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		`&`
	<		`<`
	>		`>`
	[		`[`
	]		`]`

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.