All the problems noted so far would have been pointed out to you by Perl itself if you had use warnings (or -w if your Perl is older). You could also add some indentation in your loop to show the flow better, and some error checking (e.g. die if your open fails) would help you out too. For instance, if you use warnings you should get a message about printing to a closed filehandle, and also probably a message about $text not being numeric as an array index, which would point out the error that boo_radley noted above. You will also find that use strict helps immeasurably in making you think about your use of variables.

--
I'd like to be able to assign to an luser

In reply to Re: Sub only grabbing first line from STDIN by Albannach
in thread Sub only grabbing first line from STDIN by aseidas

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.