Reading Nuke's original post, and the responses to it so far, I realized that there are different reasons for doing a code review, and the nature of the review depends on your reasons for doing the review. Some reasons I can think of off the top of my head:

• to find and fix bugs, security holes, and the like
• to find and fix design flaws and/or plan for refactoring
• to facilitate knowledge transfer to new programmers on a project
• as part of an employee performance review
• as a part of a job interview

Most likely, no single code review will be done for all of these reasons. Depending on the reasons for the review, the "important parts" of a review will be different.

Of course, these observations are made in a world larger than just PerlMonks.

Alan

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.