Hi,

I have written this little piece of code to act as a sucessful-hit logger on my home-page and i cant for the life of me get it to work.

Here's the code if anyonw wouldnt mind taking a look: 

#!/usr/bin/perl
#
# To use this just insert this line into any html file you
# want to hit:
#
#  <!--exec cgi="/cgi-bin/hitlogger.cgi"-->
#
print "Content-Type: text/html\n\n";
print "HELLO\n";

# Gather all of the log strings
$dateprog          = "/bin/date";
$server_protocol = $ENV{'SERVER_PROTOCOL'};
$remoth_host = $ENV{'HTTP_X_FORWARDED_FOR'} || $ENV{'REMOTE_ADDR'};
$user_agent      = $ENV{'HTTP_USER_AGENT'};
$request_method  = $ENV{'REQUEST_METHOD'};
$request_uri      = $ENV{'REQUEST_URI'};
$request          = "$request_method $request_uri $server_protocol";
$date              = `$dateprog`;
chomp $date;
$log_strig          = "$remote_host - - [$date] \"$request\" 200 -";

# open the log and output the log string
open( LOG, ">/home/exposu/logs/web_access.log.txt" ) || die "$!\n";
print LOG "$log_string\n";
close LOG;

[download]

Cheers,

Elfyn

In reply to is there something wrong with this code? by emcb

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.